Skip to content

Mac context menu #73882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinmc merged 38 commits into from
Jan 20, 2021
Merged

Mac context menu #73882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
c31cd9c
All desktop context menu work in one commit due to weird branching
justinmc Jan 13, 2021
5b35b1e
Split out button and basic toolbar
justinmc Jan 13, 2021
b10080c
Use shared LayoutDelegate for position, and move Content to desktop T…
justinmc Jan 13, 2021
1b6601a
No more overflow logic since this menu doesnt have special overflow b…
justinmc Jan 13, 2021
667737d
Naively position the menu at the last tap down position
justinmc Jan 13, 2021
7695fdb
Move the menu onscreen if it is hanging off
justinmc Jan 13, 2021
cbc6d55
Working toolbar builder
justinmc Jan 13, 2021
a7d9bbf
iOS=>Mac in docs and remove constants
justinmc Jan 13, 2021
2ed0b58
Delete handles
justinmc Jan 13, 2021
8cd6348
Fixed todos in button and added docs
justinmc Jan 14, 2021
9ba4abd
Merge branch 'master' into desktop-context-menu
justinmc Jan 14, 2021
4301e61
License headers
justinmc Jan 14, 2021
d7b2d99
Code cleanup
justinmc Jan 14, 2021
448aa1d
When tapping on selection, the menu fades out and back in at the new …
justinmc Jan 14, 2021
e7b35d1
Move lastTapWasOnSelection so I can make it private
justinmc Jan 14, 2021
343c2ec
Analyzer fixes
justinmc Jan 14, 2021
51c86bb
Color from theme in button
justinmc Jan 14, 2021
06017ac
Fix docs macro reference
justinmc Jan 14, 2021
be1b636
Make Mac tests use a mouse
justinmc Jan 14, 2021
06a002f
Missing trailing comma from code review
justinmc Jan 14, 2021
876534e
Improve vertical centering via padding tweak
justinmc Jan 14, 2021
b9983c8
Tweak padding to get size pixel perfect
justinmc Jan 14, 2021
bd826c4
Move another Mac test to use the mouse
justinmc Jan 14, 2021
9c69fba
Dont expose lasttapdownposition, create lastsecondarytapdownposition …
justinmc Jan 15, 2021
92805b3
Make everything private
justinmc Jan 15, 2021
88ad8a0
Dynamic hardcoded light/dark colors for background and text
justinmc Jan 15, 2021
174ff0f
Remove docs reference to desktop toolbarbuilder, now that it's private
justinmc Jan 15, 2021
31711a5
Merge branch 'master' into desktop-context-menu
justinmc Jan 15, 2021
ddfc82a
Simplify clipboard status listening logic, and other small code revie…
justinmc Jan 15, 2021
1982dee
Consistent lastSecondaryTapDown name
justinmc Jan 15, 2021
d318d0d
Fix clipboardstatus in tests, and re-add Mac tap tests since the PR n…
justinmc Jan 15, 2021
c66defc
WIP Simple test for all high level text widgets that can have a Mac c…
justinmc Jan 15, 2021
3c2de78
Correct light mode border color
justinmc Jan 16, 2021
dce1305
Mac menu test for CupertinoTextField and SelectableText
justinmc Jan 16, 2021
e437a2c
Fix references to text.dart (consolidated to editable_text_utils.dart)
justinmc Jan 16, 2021
077dab3
fix clipboard in textformfield test
justinmc Jan 16, 2021
1dbb384
Dont test the desktop text selection toolbar on web
justinmc Jan 19, 2021
f7f6e03
Merge branch 'master' into desktop-context-menu
justinmc Jan 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/flutter/lib/cupertino.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export 'src/cupertino/constants.dart';
export 'src/cupertino/context_menu.dart';
export 'src/cupertino/context_menu_action.dart';
export 'src/cupertino/date_picker.dart';
export 'src/cupertino/desktop_text_selection.dart';
export 'src/cupertino/dialog.dart';
export 'src/cupertino/form_row.dart';
export 'src/cupertino/form_section.dart';
Expand Down
Loading