Add recommended Xcode version to doctor #73808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
the
t: xcode
flutter-dashboard
bot
added
the
tool
jmagman
commented
Jan 12, 2021
| // Messages used in XcodeValidator | ||
| String xcodeLocation(String location) => 'Xcode at $location'; | ||
| String xcodeOutdated(int versionMajor, int versionMinor, int versionPatch) => | ||
| 'Flutter requires a minimum Xcode version of $versionMajor.$versionMinor.$versionPatch.\n' |
Member
Author
There was a problem hiding this comment.
I figured there's no point mentioning the minimum required if they are out of date: just download the recommended one.
| const int kXcodeRequiredVersionMinor = 0; | ||
| const int kXcodeRequiredVersionPatch = 0; | ||
|
|
||
| const int kXcodeRecommendedVersionMajor = 12; |
Contributor
There was a problem hiding this comment.
Can we replace these with our existing Version class?
Then you can just if (currentVersion >= recommendedVersion) { ... }
jmagman
commented
Jan 13, 2021
| } | ||
|
|
||
| bool get _xcodeVersionSupportsScreenshot { | ||
| return _xcode.majorVersion > 8 || (_xcode.majorVersion == 8 && _xcode.minorVersion >= 2); |
Member
Author
There was a problem hiding this comment.
I just noticed we don't need this anymore, the minimum version has been > 8 for awhile.
pcsosinski
pushed a commit
to pcsosinski/flutter
that referenced
this pull request
Jan 14, 2021
pcsosinski
pushed a commit
that referenced
this pull request
Jan 14, 2021
* Update engine hash to 1.25.0-8.3.pre * Fix dateAndTime and time modes of CupertinoDatePicker. (#73276) * Fix cupertino icons mapping which was misaligned by 1 (#72384) * Add recommended Xcode version to doctor (#73808) * Remove unnecessary Xcode version check Co-authored-by: YeungKC <[email protected]> Co-authored-by: xster <[email protected]> Co-authored-by: Jenn Magder <[email protected]>
This was referenced Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add concept of minimum recommended Xcode version (analogous to minimum recommended CocoaPods version) to give users warning that they should start upgrading their environments.
Rename
isVersionSatisfactory->isRequiredVersionSatisfactoryfor clarity.Set minimum recommended to Xcode 12.0.1 (released 9/29/20).
Fixes #73801
flutter doctor:flutter doctor -v: