Skip to content

Revert "Exclude arm64 from valid iOS simulators" #73807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Jan 12, 2021
Merged

Revert "Exclude arm64 from valid iOS simulators" #73807

jmagman merged 1 commit into from
Jan 12, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jan 12, 2021

Reverts #73755

#73511 happened again in ios_app_with_extensions_test, though it didn't reproduce for me locally. Maybe related to the version of Xcode running on that agent?

warning: Mapping architecture arm64 to x86_64. Ensure that this target's Architectures and Valid Architectures build settings are configured correctly for the iOS Simulator platform. (in target 'device_info' from project 'Pods')
stdout:     warning: There are no architectures to compile for because all architectures in VALID_ARCHS (x86_64) are also in EXCLUDED_ARCHS (x86_64, i386). (in target 'device_info' from project 'Pods')

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 12, 2021
@jmagman
Copy link
Member Author

jmagman commented Jan 12, 2021

Merging to green the build.

@google-cla google-cla bot added the cla: yes label Jan 12, 2021
@jmagman jmagman merged commit f63055a into master Jan 12, 2021
@jmagman jmagman deleted the revert-73755-exclude-archs branch January 12, 2021 21:02
@jmagman
Copy link
Member Author

jmagman commented Jan 13, 2021

It was related to the Xcode version, I reproduced this on Xcode 11.7. Looks like EXCLUDED_ARCHS isn't handled correctly for simulators on < Xcode 12

@jmagman jmagman mentioned this pull request Mar 4, 2021
Merged
@jmagman jmagman added the platform-host-arm Building on an ARM-based platform label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-host-arm Building on an ARM-based platform tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jmagman