Add [pointerCount] property to Scale Gesture Details #73474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
Hixie
reviewed
Jan 7, 2021
Hixie
reviewed
Jan 7, 2021
Hixie
reviewed
Jan 7, 2021
dkwingsmt
approved these changes
Jan 11, 2021
Contributor
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
LGTM except for tiny format issues
| /// | ||
| /// The [velocity] argument must not be null. | ||
| ScaleEndDetails({ this.velocity = Velocity.zero }) | ||
| ScaleEndDetails({ this.velocity = Velocity.zero, this.pointerCount = 0, }) |
Contributor
There was a problem hiding this comment.
Suggested change
| ScaleEndDetails({ this.velocity = Velocity.zero, this.pointerCount = 0, }) | |
| ScaleEndDetails({ this.velocity = Velocity.zero, this.pointerCount = 0 }) |
I've searched around the repo and have found 2 use cases of , }), including one in this file. It's safe to assume to be a typo.
| /// | ||
| /// The [focalPoint] argument must not be null. | ||
| ScaleStartDetails({ this.focalPoint = Offset.zero, Offset? localFocalPoint, }) | ||
| ScaleStartDetails({ this.focalPoint = Offset.zero, Offset? localFocalPoint, this.pointerCount = 0, }) |
Contributor
There was a problem hiding this comment.
Suggested change
| ScaleStartDetails({ this.focalPoint = Offset.zero, Offset? localFocalPoint, this.pointerCount = 0, }) | |
| ScaleStartDetails({ this.focalPoint = Offset.zero, Offset? localFocalPoint, this.pointerCount = 0 }) |
flutter-dashboard
bot
added
the
f: material design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context addresses #13101 (comment) and #13102
Adding
pointerCountproperty to scale gesture details is useful for developers. Use it to distinguish the scale caused by pan(one finger) and zoom(more than one finger) gesture.CC @Hixie
Fixes #13102
Fixes #49025