Fix dateAndTime and time modes of CupertinoDatePicker. #73276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: cupertino
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Gold has detected about 15 untriaged digest(s) on patchset 1. |
|
Gold has detected about 47 untriaged digest(s) on patchset 2. |
…Picker's_selectionOverlay
pcsosinski
pushed a commit
to pcsosinski/flutter
that referenced
this pull request
Jan 14, 2021
pcsosinski
pushed a commit
that referenced
this pull request
Jan 14, 2021
* Update engine hash to 1.25.0-8.3.pre * Fix dateAndTime and time modes of CupertinoDatePicker. (#73276) * Fix cupertino icons mapping which was misaligned by 1 (#72384) * Add recommended Xcode version to doctor (#73808) * Remove unnecessary Xcode version check Co-authored-by: YeungKC <[email protected]> Co-authored-by: xster <[email protected]> Co-authored-by: Jenn Magder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This error ui was introduced by me in #65501.
before:
#73203 (comment)
after:
Related Issues
close #73203
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behavior with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.
@xster
Should we do all mode golden tests to prevent such issues from happening again?