Default add-to-app xcode_backend script to be verbose #73110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
platform-ios
flutter-dashboard
bot
added
the
tool
xster
approved these changes
Jan 6, 2021
Member
There was a problem hiding this comment.
can we add a comment or rename the private method to make it harder to accidentally refactor the normal flow to use this script and get verbose? e.g. make the verbose <-> script <-> add-to-app linkage more explicit?
Member
Author
There was a problem hiding this comment.
You're right, I can move this to a more explicit add-to-app spot.
Member
Author
There was a problem hiding this comment.
Moved it into the pod script phase.
jmagman
force-pushed
the
verbose-add2app
branch
from
e4f4ab0 to
9a25e87
Compare
jmagman
commented
Jan 7, 2021
| 'Host', | ||
| '-configuration', | ||
| 'Debug', | ||
| 'ARCHS=i386', // i386 is not supported in Debug mode. |
Member
Author
There was a problem hiding this comment.
This was actually failing in CocoaPods before the Flutter script could run.
Member
Author
|
@xster Does this still LGT[u]? I rewrote it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's no
flutter run --verboseavailable for host add-to-app to see whyassemblefailed. Until we can emit better, more focused error messages, default to making the script run in verbose mode so it can be seen in the Xcode build logs.This matches macOS app behavior.
Related Issues
Fixes #70329
Tests
create_test