UserAccountsDrawerHeader gallery demo, etc #7297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarth
reviewed
Dec 21, 2016
| return Icons.arrow_back; | ||
| case TargetPlatform.iOS: | ||
| return Icons.arrow_back_ios; | ||
| } |
Contributor
There was a problem hiding this comment.
We should have a helper function somewhere that does this for you (given a TargetPlatform)
Contributor
Author
There was a problem hiding this comment.
I will file an issue. I think we need to think about how to deal with platform-specific icons (and maybe other assets) in general.
abarth
reviewed
Dec 21, 2016
| children: <Widget>[ | ||
| new UserAccountsDrawerHeader( | ||
| accountName: new Text('Zach Widget'), | ||
| accountEmail: new Text('[email protected]'), |
Contributor
There was a problem hiding this comment.
Probably should use example.com given that we don't don't own flutter.com
abarth
reviewed
Dec 21, 2016
| Widget accountNameLine = accountName == null ? null : new DefaultTextStyle( | ||
| style: const TextStyle( | ||
| fontWeight: FontWeight.w500, | ||
| color: Colors.white, |
Contributor
There was a problem hiding this comment.
Does not come from one of the premade text themes?
Contributor
Author
There was a problem hiding this comment.
Yes! Theme.of(context).accentTextTheme.body1,2 do the right thing.
Contributor
|
|
Hixie
reviewed
Dec 21, 2016
| @@ -0,0 +1,185 @@ | |||
| // Copyright 2015 The Chromium Authors. All rights reserved. | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a UserAccountsDrawerHeader gallery demo.
Also made some tweaks to the UserAccountsDrawerHeader implementation:
Fixes #7191
Fixes #7192