Skip to content

[flutter_releases] Flutter Beta 1.25.0-8.2 Framework Cherrypicks #72754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christopherfujino merged 1 commit into from
Jan 5, 2021
Merged

[flutter_releases] Flutter Beta 1.25.0-8.2 Framework Cherrypicks #72754

christopherfujino merged 1 commit into from
Jan 5, 2021

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Dec 21, 2020

Cherrypick of PR #71964 to fix #72627.

This CP has NOT been approved yet, and thus should not be merged without approval from @pcsosinski.

@flutter-dashboard flutter-dashboard bot added engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 21, 2020
@google-cla google-cla bot added the cla: yes label Dec 21, 2020
@christopherfujino christopherfujino changed the base branch from master to flutter-1.25-candidate.8 December 21, 2020 21:37
@flutter-dashboard
Copy link

flutter-dashboard bot commented Dec 21, 2020

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

pcsosinski
pcsosinski approved these changes Jan 5, 2021
View reviewed changes
Copy link

@pcsosinski pcsosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve for branch

@christopherfujino christopherfujino merged commit b0a2299 into flutter:flutter-1.25-candidate.8 Jan 5, 2021
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.25-candidate.8 branch January 5, 2021 20:34
@cyanglaz cyanglaz mentioned this pull request Jan 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pcsosinski pcsosinski pcsosinski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Regression] [Beta] : Cannot build apk on Flutter 1.25.0-8.1.pre (applies to example apps for Flutter plugins too)

2 participants

@christopherfujino @pcsosinski