Exclude ARM from macOS builds #72748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
jmagman
force-pushed
the
macos-exclude
branch
from
0c574df to
f244f28
Compare
gw280
approved these changes
Dec 21, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that the macOS Podfile logic is in the tool, we can exclude arm64 for plugins without a scary user project Podfile migration.
Exclude arm64 for plugins and the app. Revert #70649 since it's handled in the Xcode build settings and so doesn't need to be passed in the command line. This will allow building/running/archiving in Release mode in Xcode instead of just working on via
flutteron the command line.Related Issues
Fixes #70566
Can be reverted when arm64 is natively supported #69221
Reverts #70649
Tests
build_macos_test, build_ios_config_only_test