Skip to content

Improve docs for Input and Form and friends. #7208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpcomplete merged 1 commit into from
Dec 12, 2016
Merged

Improve docs for Input and Form and friends. #7208

mpcomplete merged 1 commit into from
Dec 12, 2016

Conversation

@mpcomplete
Copy link
Contributor

@mpcomplete mpcomplete commented Dec 8, 2016

Fixes #7017

@mpcomplete mpcomplete requested a review from Hixie December 8, 2016 23:00
Hixie
Hixie reviewed Dec 9, 2016
View reviewed changes
packages/flutter/lib/src/material/input.dart Outdated
Copy link
Contributor

@Hixie Hixie Dec 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline after the first sentence.

Rather than just directing people elsewhere in this style, we usually say something like "This widget is useful if baz. If you want foo, consider bar."

Hixie
Hixie reviewed Dec 9, 2016
View reviewed changes
packages/flutter/lib/src/material/input.dart Outdated
Copy link
Contributor

@Hixie Hixie Dec 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/in focus/focused/

Hixie
Hixie reviewed Dec 9, 2016
View reviewed changes
packages/flutter/lib/src/material/input.dart Outdated
Copy link
Contributor

@Hixie Hixie Dec 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the keyboard

Hixie
Hixie reviewed Dec 9, 2016
View reviewed changes
packages/flutter/lib/src/material/input.dart Outdated
Copy link
Contributor

@Hixie Hixie Dec 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Input]

Copy link
Contributor

@Hixie Hixie Dec 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and [State.setState]

Hixie
Hixie reviewed Dec 9, 2016
View reviewed changes
packages/flutter/lib/src/material/input.dart Outdated
Copy link
Contributor

@Hixie Hixie Dec 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two

Hixie
Hixie reviewed Dec 9, 2016
View reviewed changes
packages/flutter/lib/src/material/input.dart Outdated
Copy link
Contributor

@Hixie Hixie Dec 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Note://

Hixie
Hixie reviewed Dec 9, 2016
View reviewed changes
packages/flutter/lib/src/material/input.dart Outdated
Copy link
Contributor

@Hixie Hixie Dec 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here and the cases below, s/val/value/

Hixie
Hixie reviewed Dec 9, 2016
View reviewed changes
packages/flutter/lib/src/material/input.dart Outdated
Copy link
Contributor

@Hixie Hixie Dec 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap this so it's longer, to make it obvious that there's more going on here than in the other example

@Hixie
Copy link
Contributor

Hixie commented Dec 9, 2016

This is great. LGTM with the above changes.

@mpcomplete mpcomplete merged commit 7d346dd into flutter:master Dec 12, 2016
@mpcomplete mpcomplete deleted the docs branch December 12, 2016 19:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Hixie Hixie Hixie left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

InputFormField needs better docs

3 participants

@mpcomplete @Hixie @googlebot