Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Dec 8, 2020

Description

Add macOS plugin integration tests. Validate output, Podfile.lock.

Swap from device_info to url_launcher and url_launcher_macos.

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. platform-mac Building on or for macOS specifically labels Dec 8, 2020
@jmagman jmagman self-assigned this Dec 8, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits.

@jmagman jmagman merged commit 53119af into flutter:master Dec 9, 2020
@jmagman jmagman deleted the lint-mac-plugins branch December 9, 2020 21:35
@jmagman jmagman added the a: tests "flutter test", flutter_test, or one of our tests label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. platform-mac Building on or for macOS specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants