Skip to content

Revert "Move embedding and linking macOS Flutter frameworks into the tool" #71951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Dec 8, 2020
Merged

Revert "Move embedding and linking macOS Flutter frameworks into the tool" #71951

jmagman merged 1 commit into from
Dec 8, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Dec 8, 2020

Reverts #71764

hot_mode_dev_cycle_macos_target__benchmark is failing.

2020-12-08T14:22:03.476319: stdout: [ +341 ms] 2020-12-08 14:22:03.475 flutter_gallery[38930:24214860] Failed to find path for "flutter_assets"
2020-12-08T14:22:03.477822: stdout: [   +1 ms] 2020-12-08 14:22:03.475 flutter_gallery[38930:24214860] Failed to find path for "flutter_assets"
stdout: [        ] embedder.cc (764): 'FlutterEngineInitialize' returned 'kInvalidArguments'. The assets path in the Flutter project arguments was missing.
stdout: [        ] 2020-12-08 14:22:03.475 flutter_gallery[38930:24214860] Failed to initialize Flutter engine: error 2
2020-12-08T15:22:20.615880: Task execution finished

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 8, 2020
@google-cla google-cla bot added the cla: yes label Dec 8, 2020
@jmagman jmagman merged commit c88ab79 into master Dec 8, 2020
@jmagman jmagman deleted the revert-71764-macos-link-tool branch December 8, 2020 23:28
@jmagman jmagman mentioned this pull request Dec 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jmagman