Skip to content

Rename IOSMigrator -> ProjectMigrator #71757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Dec 5, 2020
Merged

Rename IOSMigrator -> ProjectMigrator #71757

jmagman merged 1 commit into from
Dec 5, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Dec 5, 2020

Description

I'm about to create a macOS project migration. Rename IOSMigrator to ProjectMigrator and move from ios/migrations to base/project_migrator.dart to make it more generic.

Related Issues

Will be used to migrate #56581.

@jmagman jmagman added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 5, 2020
@jmagman jmagman self-assigned this Dec 5, 2020
@google-cla google-cla bot added the cla: yes label Dec 5, 2020
christopherfujino
christopherfujino approved these changes Dec 5, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit aa7be00 into flutter:master Dec 5, 2020
@jmagman jmagman deleted the project-migrator branch December 5, 2020 02:35
@jpnurmi jpnurmi mentioned this pull request Dec 6, 2020
Merged
10 tasks
@jmagman jmagman mentioned this pull request Dec 8, 2020
Merged
@gnprice gnprice mentioned this pull request Mar 19, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso Awaiting requested review from zanderso

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @christopherfujino