Reland integration template #71740
Merged
Reland integration template #71740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
thecalamiity
reviewed
Dec 4, 2020
| print(result.stdout); | ||
| print('================================= STDERR ======================================='); | ||
| print(result.stderr); | ||
| fail('flutter drive failed, see output.'); |
Contributor
There was a problem hiding this comment.
This is probably flutter driver* right?
Contributor
Author
There was a problem hiding this comment.
No, this is referring to the command flutter drive (which is unfortunately easily confused with and definitely related to flutter_driver).
Contributor
Author
There was a problem hiding this comment.
No worries, thanks for looking!
Contributor
Author
|
The PR that fixed functionality this depends on has landed. |
Contributor
Author
|
I'm going to file a follow up PR to address updating the default iOS project to support running a test out of the box without flutter drive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must not be landed until after #71738
Otherwise this is an identical reland. The linked PR fixes a bug in our Android build logic to make this work now.
/cc @blasten @jonahwilliams @Piinks