Skip to content

Conversation

@blasten
Copy link

@blasten blasten commented Dec 4, 2020

Description

Currently, a project doesn't build if it includes a plugin and also defines a flavor or custom build type.

Related Issues

Fixes #71694

Tests

I added the following tests: e2e

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@blasten blasten requested a review from dnfield December 4, 2020 20:21
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 4, 2020
@google-cla google-cla bot added the cla: yes label Dec 4, 2020
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the quick fix

@dnfield dnfield added platform-android Android applications specifically t: gradle "flutter build" and "flutter run" on Android labels Dec 4, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux gradle_plugin_light_apk_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_gallery has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac gradle_plugin_light_apk_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows gradle_plugin_light_apk_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit d35dd9f into flutter:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-android Android applications specifically t: gradle "flutter build" and "flutter run" on Android tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building with a custom Gradle build type fails if plugins are present.

4 participants