Create symlinks for local engine Maven metadata files required by the Android Gradle plugin #71600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
tool
blasten
approved these changes
Dec 2, 2020
blasten
left a comment
blasten
left a comment
There was a problem hiding this comment.
There are some test cases in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/android/gradle_test.dart#L1695, so this can be tested there.
LGTM % update tests
jason-simmons
force-pushed
the
bug_65399
branch
from
81cebb7 to
6f38c9d
Compare
… Android Gradle plugin See flutter#65399
jason-simmons
force-pushed
the
bug_65399
branch
from
6f38c9d to
aa139ff
Compare
Contributor
|
@jason-simmons is this safe to submit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65399