Skip to content

Revert "Fix excessive rebuilds of DSS" #71459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnfield merged 1 commit into from
Dec 2, 2020
Merged

Revert "Fix excessive rebuilds of DSS" #71459

dnfield merged 1 commit into from
Dec 2, 2020

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Dec 1, 2020

Reverts #69724

This definitely caused issues for hot reload, and is likely the cause of #70690

@dnfield dnfield requested a review from HansMuller December 1, 2020 04:52
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Dec 1, 2020
@google-cla google-cla bot added the cla: yes label Dec 1, 2020
@dnfield dnfield mentioned this pull request Dec 1, 2020
Closed
Piinks
Piinks approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@dnfield dnfield merged commit a2aa2ed into master Dec 2, 2020
@dnfield dnfield deleted the revert-69724-drag_build branch December 2, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dnfield @Piinks