Skip to content

Update CocoaPods minimum version to 1.9 #71170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 2 commits into from
Dec 17, 2020
Merged

Update CocoaPods minimum version to 1.9 #71170

jmagman merged 2 commits into from
Dec 17, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 24, 2020 •
edited
Loading

Description

CocoaPods 1.9 introduced support for xcframeworks. It was released in February 2020.

Related Issues

#69809 is in 1.24.0-10.1.pre (currently dev and beta). This change will be in flutter-1.25-candidate.* so the recommended minimum nudge should make it to stable before this harsher minimum requirement.

@jmagman jmagman self-assigned this Nov 24, 2020
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 24, 2020
@google-cla google-cla bot added the cla: yes label Nov 24, 2020
@jmagman jmagman added the t: xcode "xcodebuild" on iOS and general Xcode project management label Nov 24, 2020
@jmagman
Copy link
Member Author

jmagman commented Nov 24, 2020

#69809 is in 1.24.0-10.1.pre (currently dev and beta). This change will be in flutter-1.25-candidate.* so the recommended minimum nudge should make it a stable before this harsher minimum requirement.

@christopherfujino this is true, right?

@jmagman
Copy link
Member Author

jmagman commented Nov 24, 2020

Blocked by #69829

@jmagman jmagman mentioned this pull request Nov 24, 2020
Closed
This was referenced Nov 30, 2020
Closed
Merged
@jmagman
Copy link
Member Author

jmagman commented Dec 15, 2020

I think I upgraded all the agents. Let's merge, I'll revert if something breaks post-submit.

christopherfujino
christopherfujino reviewed Dec 15, 2020
View reviewed changes
packages/flutter_tools/lib/src/macos/cocoapods_validator.dart Outdated
Copy link
Contributor

@christopherfujino christopherfujino Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also delete this user message?

Copy link
Member Author

@jmagman jmagman Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that, good eye.

christopherfujino
christopherfujino approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit about removing the user message, otherwise this is great! LGTM

@jmagman jmagman merged commit 23f5fbc into flutter:master Dec 17, 2020
@jmagman jmagman deleted the cocoapods-min branch December 17, 2020 18:22
@blasten
Copy link

blasten commented Dec 18, 2020

This change appears to be causing the issues seen in https://github.com/flutter/plugins/pull/3342/checks?check_run_id=1573661704. Is this considered a breaking change?

@jmagman jmagman mentioned this pull request Dec 18, 2020
Merged
@jmagman
Copy link
Member Author

jmagman commented Dec 21, 2020

@blasten it's not a breaking change, I just had to update plugin's CI to an updated version of CocoaPods. flutter/plugins#3347

@jmagman jmagman mentioned this pull request Jan 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @blasten @christopherfujino