Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 23, 2020

Description

Add unused Artifact.flutterXcframework to get ready for the XCFramework being added to the uploaded engine artifacts.

Pass EnvironmentType into the artifacts logic. This will be used to differentiate Flutter.xcframework/ios-x86_64-simulator/Flutter.framework from Flutter.xcframework/ios-arm64_armv7/Flutter.framework. Parse the environment (iOS vs iOS simulator) in the ios build system target.

Related Issues

Will be used as part of #60109 when the xcframework is added to artifacts.

Tests

artifacts test, ios build system target test

@jmagman jmagman added the platform-ios iOS applications specifically label Nov 23, 2020
@jmagman jmagman self-assigned this Nov 23, 2020
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 23, 2020
@google-cla google-cla bot added the cla: yes label Nov 23, 2020
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Nov 24, 2020

Google test failing because #71095 hasn't been rolled yet.

@jmagman
Copy link
Member Author

jmagman commented Nov 30, 2020

Flutter.xcframework will be in the artifacts once flutter/engine@81af789 or later rolls to the framework.

Recipe changed merged at https://flutter.googlesource.com/recipes/+/d3f2a7ef840805c27163a0b274f15a05cc3401e4

@jmagman jmagman merged commit a5ee7f7 into flutter:master Dec 1, 2020
@jmagman jmagman deleted the artifact-xcf branch December 1, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants