Skip to content

Move Flutter.podspec to add-to-app project template #71103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 5 commits into from
Nov 24, 2020
Merged

Move Flutter.podspec to add-to-app project template #71103

jmagman merged 5 commits into from
Nov 24, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 23, 2020

Description

Flutter.podspec is only used in add-to-app modules. Stop using the one shipped in the engine artifacts and instead generate from the tool template.

This doesn't need a migration--previous versions of Flutter have already copied an identical Flutter.podspec to that spot, and flutter clean totally recreates .ios anyway.

Related Issues

#60109 will require Flutter.podspec to change to s.vendored_frameworks = 'Flutter.xcframework'. It will be easier to handle this migration in the tool instead of coordinating a framework repo change with the right engine roll.

Tests

Added file to create_test. This logic is also tested in module_test_ios and build_ios_framework_module_test.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 23, 2020
@google-cla google-cla bot added the cla: yes label Nov 23, 2020
@jmagman jmagman self-assigned this Nov 24, 2020
@jmagman jmagman added a: existing-apps Integration with existing apps via the add-to-app flow platform-ios iOS applications specifically labels Nov 24, 2020
@jmagman jmagman merged commit 9bbc217 into flutter:master Nov 24, 2020
@jmagman jmagman deleted the a2a-podspec branch November 24, 2020 18:16
@jmagman jmagman mentioned this pull request Dec 1, 2020
Merged
@oshtman oshtman mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

@jmagman jmagman

Labels

a: existing-apps Integration with existing apps via the add-to-app flow platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jmagman