Skip to content

Make simulator framework test check explicit #71100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Nov 23, 2020
Merged

Make simulator framework test check explicit #71100

fluttergithubbot merged 1 commit into from
Nov 23, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 23, 2020

Description

Pull Debug==simulator logic out of _checkFrameworkArchs and up to where it's called to check each framework.

Related Issues

Will be used as part of #60109 because release and profile Flutter.xcframework will also contain simulator archs, just like Flutter.framework does now.

@jmagman jmagman added platform-ios iOS applications specifically a: existing-apps Integration with existing apps via the add-to-app flow labels Nov 23, 2020
@jmagman jmagman self-assigned this Nov 23, 2020
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Nov 23, 2020
@google-cla google-cla bot added the cla: yes label Nov 23, 2020
@jmagman
Copy link
Member Author

jmagman commented Nov 23, 2020

Passed: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20build_ios_framework_module_test/1483/overview

christopherfujino
christopherfujino approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 39155dc into flutter:master Nov 23, 2020
@jmagman jmagman deleted the build-ios-fw-sim branch November 23, 2020 22:22
@jmagman jmagman mentioned this pull request Dec 1, 2020
Merged
@oshtman oshtman mentioned this pull request May 19, 2021
Closed
@jmagman jmagman added the a: tests "flutter test", flutter_test, or one of our tests label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: existing-apps Integration with existing apps via the add-to-app flow a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @christopherfujino @fluttergithubbot