Skip to content

Rename SdkType -> EnvironmentType #71095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Nov 23, 2020
Merged

Rename SdkType -> EnvironmentType #71095

fluttergithubbot merged 1 commit into from
Nov 23, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 23, 2020

Description

Rename SdkType to EnvironmentType to make it more generic than just the SDK used to build.

The macOS code path was unused.

Related Issues

Will be used as part of #60109 to specify simulator and non-simulator engine framework paths.

@jmagman jmagman added the platform-ios iOS applications specifically label Nov 23, 2020
@jmagman jmagman self-assigned this Nov 23, 2020
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 23, 2020
@google-cla google-cla bot added the cla: yes label Nov 23, 2020
christopherfujino
christopherfujino approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Nov 23, 2020

Google test is failing because downstream hasn't picked up #70898, which removed AotBuilder.

@fluttergithubbot fluttergithubbot merged commit 3a479e7 into flutter:master Nov 23, 2020
@jmagman jmagman deleted the env-type branch November 23, 2020 22:22
@jmagman jmagman mentioned this pull request Nov 24, 2020
Merged
@jmagman jmagman mentioned this pull request Dec 1, 2020
Merged
@oshtman oshtman mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @christopherfujino @fluttergithubbot