Remove unneeded analyzer ignores #7109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need these anymore.
Contributor
Author
Hixie
reviewed
Nov 30, 2016
| height: itemHeight, | ||
| padding: const EdgeInsets.symmetric(horizontal: 16.0), | ||
| child: new Row( | ||
| crossAxisAlignment: CrossAxisAlignment.center, |
Contributor
There was a problem hiding this comment.
was this an intentional change?
Contributor
Author
There was a problem hiding this comment.
Yes, this is the default value.
Hixie
reviewed
Nov 30, 2016
| return null; | ||
| // TODO(ianh): JSON decoding really shouldn't be on the main thread. | ||
| final Map<dynamic, dynamic> parsedManifest = JSON.decode(json); | ||
| final Map<String, List<String>> parsedManifest = JSON.decode(json); |
Contributor
There was a problem hiding this comment.
that's not right. JSON.decode will not return a Map<String, List<String>>. It has a return type of dynamic and (if the JSON is what we expect) return a Map<String, dynamic> that happens to only contain List<String>s.
Hixie
reviewed
Nov 30, 2016
| final Map<String, List<String>> parsedManifest = JSON.decode(json); | ||
| // TODO(ianh): convert that data structure to the right types. | ||
| return new SynchronousFuture<Map<dynamic, dynamic>>(parsedManifest); // ignore: return_of_invalid_type, https://github.com/flutter/flutter/issues/5771 | ||
| return new SynchronousFuture<Map<String, List<String>>>(parsedManifest); |
Contributor
There was a problem hiding this comment.
This should fail in strong mode, since it's an invalid cast, as far as I can tell.
Hixie
reviewed
Nov 30, 2016
| GlobalKey globalKey = key; | ||
| return globalKey.currentState; // ignore: return_of_invalid_type, https://github.com/flutter/flutter/issues/5771 | ||
| GlobalKey<T> globalKey = key; | ||
| return globalKey.currentState; |
Contributor
There was a problem hiding this comment.
huh. I thought I'd tried that and it didn't work for some reason. Weird.
Contributor
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need these anymore.