Skip to content

[BottomNavigationBar] Adds more control to ToolTip #71079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 13 commits into from
Dec 16, 2020
Merged

[BottomNavigationBar] Adds more control to ToolTip #71079

fluttergithubbot merged 13 commits into from
Dec 16, 2020

Conversation

@yash1200
Copy link
Contributor

@yash1200 yash1200 commented Nov 23, 2020 •
edited
Loading

Description

This PR adds showToolTip property in BottomNavigationBar and toolTip property in BottomNavigationBarItem.

Related Issues

Fixes #71049

Tests

I added the following tests:

  • Shows custom ToolTip message if it is provided in BottomNavigationBarItem
  • Doesn't show tool tip if showToolTip is false.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 23, 2020
@google-cla google-cla bot added the cla: yes label Nov 23, 2020
@yash1200 yash1200 changed the title Added showToolTip in BottomNavigationBar [BottomNavigationBar] Adds more control to ToolTip Nov 23, 2020
@Hixie
Copy link
Contributor

Hixie commented Nov 26, 2020

Setting tooltip to the empty string might be a cleaner way to hide tooltips, it avoids adding more API surface and uses a value that otherwise has no useful purpose and that pretty naturally represents "no tooltip".

@Hixie
Copy link
Contributor

Hixie commented Nov 26, 2020

cc @HansMuller

LongCatIsLooong
LongCatIsLooong reviewed Dec 11, 2020
View reviewed changes
LongCatIsLooong
LongCatIsLooong approved these changes Dec 13, 2020
View reviewed changes
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the comprehensive test cases.

@yash1200
Copy link
Contributor Author

yash1200 commented Dec 16, 2020

@LongCatIsLooong I think this should be merged now.

@fluttergithubbot fluttergithubbot merged commit 04c104c into flutter:master Dec 16, 2020
@yash1200 yash1200 deleted the bnb branch December 16, 2020 17:41
@oshtman oshtman mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BottomNavigationBar has no option to remove tooltip or change the tooltip from its icon label [Web] [Desktop]

4 participants

@yash1200 @Hixie @LongCatIsLooong @fluttergithubbot