Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 19, 2020

Description

CocoaPods crashes on ARM Macs if the x86 version of the ffi gem isn't installed.

Detect this crash and tell users how to fix it.

Screen Shot 2020-11-19 at 12 41 11 PM

Related Issues

#70796

Tests

cocoapods_tests

@jmagman jmagman added the platform-mac Building on or for macOS specifically label Nov 19, 2020
@jmagman jmagman self-assigned this Nov 19, 2020
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 19, 2020
@google-cla google-cla bot added the cla: yes label Nov 19, 2020
usage: usage,
);
pretendPodVersionIs('1.8.0');
pretendPodVersionIs('1.9.0');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been updated with #69809 and was mucking up the error text.

..createSync()
..writeAsStringSync('Existing Podfile');

when(mockProcessManager.runSync(<String>['sysctl', 'hw.optional.arm64']))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this file to my mental list to swap to FakeProcessManager. Make the new tests match the rest of the file, for now.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform-host-arm Building on an ARM-based platform platform-mac Building on or for macOS specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants