Force regeneration of old Podfile #70735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
platform-ios
jmagman
force-pushed
the
deprecate-old-podfile
branch
from
70d4ed4 to
19228cf
Compare
jmagman
commented
Nov 18, 2020
|
|
||
| final bool didPodInstall = await globals.cocoaPods.processPods( | ||
| xcodeProject: xcodeProject, | ||
| engineDir: flutterFrameworkDir(buildMode), |
Member
Author
There was a problem hiding this comment.
This is wrong on macOS and is pointing to the iOS engine artifacts directory, not sure how (if) it's working on macOS...
zanderso
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#59044 migrated the Podfile logic into the tool, and #59201 introduced a soft warning encouraging users to regenerate their Podfile (available in 1.20.0-1.0.pre, 2 stables ago). As of #70224 the Flutter framework search paths are hooked up in the tool-side code, so apps with the old Podfile won't compile anymore (Flutter.framework won't be found).
FLUTTER_FRAMEWORK_DIRbuild setting logic for iOS. It's still needed for macOS.flutter/packages/flutter_tools/templates/cocoapods/Podfile-macos
Line 63 in dda74a1
Tests
runs macOS pod install, if Manifest.lock is missingFLUTTER_FRAMEWORK_DIRcheck tomacOS build supports standard desktop build options