Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 16, 2020

Description

Before this change flutter build macos --release failed even on an x86 mac because release builds include all "valid" architectures, which includes arm64 on Xcode 12.

Exclude arm64 from macOS builds until that architecture can be added to the FlutterMacOS.framework.

This "fixes" commands from flutter tooling, but not Xcode. Archiving from Xcode would still fail.

Related Issues

#70566

Tests

build_macos_test

@jmagman jmagman added the platform-mac Building on or for macOS specifically label Nov 16, 2020
@jmagman jmagman self-assigned this Nov 16, 2020
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 16, 2020
@google-cla google-cla bot added the cla: yes label Nov 16, 2020
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added waiting for tree to go green t: xcode "xcodebuild" on iOS and general Xcode project management labels Nov 16, 2020
@fluttergithubbot fluttergithubbot merged commit 148ae7b into flutter:master Nov 16, 2020
@jmagman jmagman deleted the macos-build-arm branch November 16, 2020 22:53
@stuartmorgan-g
Copy link
Contributor

Thanks!

@jmagman jmagman added the platform-target-arm Targeting an ARM-based platform label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform-mac Building on or for macOS specifically platform-target-arm Targeting an ARM-based platform t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants