Skip to content

Revert "Actually consume top padding in bottomsheet if scrollcontrolled" #70392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Nov 13, 2020
Merged

Revert "Actually consume top padding in bottomsheet if scrollcontrolled" #70392

fluttergithubbot merged 1 commit into from
Nov 13, 2020

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Nov 12, 2020 •
edited
Loading

Reverts #66257

FYI @Kavantix
This was found to break some valid use cases in further google testing. We may have to come up with a different approach.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 12, 2020
@google-cla google-cla bot added the cla: yes label Nov 12, 2020
HansMuller
HansMuller approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Kavantix
Copy link
Contributor

Kavantix commented Nov 12, 2020

What were these usecases?

@Piinks
Copy link
Contributor Author

Piinks commented Nov 12, 2020

I've re-opened #39205, let's move discussion there. :)

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Nov 12, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_gallery has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 477a424 into master Nov 13, 2020
@fluttergithubbot fluttergithubbot deleted the revert-66257-bottomsheet-top-padding branch November 13, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Piinks @Kavantix @fluttergithubbot @HansMuller