Methods in build_ios_framework for universal and XCFrameworks #69736
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
tool
jmagman
force-pushed
the
refactor-build-ios
branch
from
0dafdeb to
a3ac81f
Compare
| podProduct as Directory, | ||
| if (mode == BuildMode.debug) | ||
| simulatorBuildConfiguration | ||
| .childDirectory(builtProduct.basename) |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jmagman
added
a: existing-apps
| continue; | ||
| } | ||
| final String binaryName = globals.fs.path.basenameWithoutExtension(podFrameworkName); | ||
| if (boolArg('universal')) { |
There was a problem hiding this comment.
This logic is now in _produceUniversalFramework.
| } | ||
| } | ||
|
|
||
| if (boolArg('xcframework')) { |
There was a problem hiding this comment.
This logic is now in _produceXCFramework
jmagman
added
waiting for tree to go green
and removed
waiting for tree to go green
labels
jmagman
added
platform-host-arm
3 participants
Description
#69731 and the next "Remove lipoing from debug stub framework step" PR were too big to review together.
Refactoring part of
build_ios_frameworkto keep the reviews for #69334 small._produceXCFrameworkto_produceXCFrameworkFromUniversal. This existing method took a universal (fat) framework, split it intoiphoneosandiphonesimulatorframeworks, then turned them into an xcframework._producePlugins, combine with logic from_produceNonDebugXCFramework, and call the new method_produceXCFramework. This method will be used in the next PR.lipotogether non-fat frameworks into a universal framework out of_producePluginsand call it_produceUniversalFramework. This method will also be used in the next PR.Related Issues
Fixes #63508, will supersede #66541
Tests
build_ios_framework_module_testthoroughly tests the output bundles. My test suggestion in #66541 (review) wasn't a great one and it didn't work.build_ios_framework_module_testwill confirm it doesn't regress the more normal case that the module and framework are named the same thing.