-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Deprecate build ios-framework --universal #69720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| ..addFlag('universal', | ||
| help: 'Produce universal frameworks that include all valid architectures. ' | ||
| 'This is true by default.', | ||
| defaultsTo: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a https://flutter.dev/docs/release/breaking-changes page if we're changing the default perhaps? Is there any user actions possibly needed for the integrator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't usually do that for tool changes, though the integrator would need to pass in --universal --no-xcframework now to get the old default behavior.
@zanderso what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as the guidance from the tool itself is clear about what is going on, then that is usually sufficient.
| help: 'Produce a Flutter.podspec instead of an engine Flutter.xcframework (recommended if host app uses CocoaPods).', | ||
| ) | ||
| ..addOption('output', | ||
| abbr: 'o', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like we never built in flag options to let users choose the target-platforms (like Android). Do you think we should?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's flutter build ios-framework it doesn't support other platforms.
|
Samples updated at flutter/samples#582 |
Description
Universal (fat) frameworks that support physical devices and simulators aren't possible in an ARM simulator world since the arm64
iphoneosandiphonesimulatorslices can't belipod together. Deprecate and hide--universaland make--xcframeworkthe default.--universalwill need to be hard deprecated (removed) when the ARM simulator Flutter.framework ships.Related Issues
Fixes #69718
Tests
Updated
build_ios_framework_module_test.