Skip to content

Revert "Build App.framework directly to build directory" #69641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Nov 3, 2020
Merged

Revert "Build App.framework directly to build directory" #69641

jonahwilliams merged 1 commit into from
Nov 3, 2020

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Nov 3, 2020

Reverts #69612

Failing ios_content_validation test:

════════════════════════╡ ••• Xcode backend script ••• ╞════════════════════════

2020-11-02T19:21:23.317623: 
Executing: /Users/flutter/.cocoon/flutter/packages/flutter_tools/bin/xcode_backend.sh embed_and_thin in /Users/flutter/.cocoon/flutter/dev/devicelab with environment {SOURCE_ROOT: /var/folders/td/jlh092g928l86qfb9gs3dfvc0000gn/T/flutter_devicelab_gradle_plugin_test.U3lQ2v/hello/ios, TARGET_BUILD_DIR: /var/folders/td/jlh092g928l86qfb9gs3dfvc0000gn/T/flutter_devicelab_gradle_plugin_test.U3lQ2v/hello/build/ios/iphoneos, FRAMEWORKS_FOLDER_PATH: Runner.app/Frameworks, VERBOSE_SCRIPT_LOGGING: 1, FLUTTER_BUILD_MODE: release, ACTION: install}
2020-11-02T19:21:23.325129: stdout: ♦ mkdir -p -- /var/folders/td/jlh092g928l86qfb9gs3dfvc0000gn/T/flutter_devicelab_gradle_plugin_test.U3lQ2v/hello/build/ios/iphoneos/Runner.app/Frameworks
2020-11-02T19:21:23.329468: stdout: ♦ rsync -av --delete --filter - .DS_Store/ /App.framework /var/folders/td/jlh092g928l86qfb9gs3dfvc0000gn/T/flutter_devicelab_gradle_plugin_test.U3lQ2v/hello/build/ios/iphoneos/Runner.app/Frameworks
2020-11-02T19:21:23.334435: stdout: building file list ... done
stderr: rsync: link_stat "/App.framework" failed: No such file or directory (2)
stdout: 
stdout: sent 29 bytes  received 20 bytes  98.00 bytes/sec
stdout: total size is 0  speedup is 0.00
stderr: rsync error: some files could not be transferred (code 23) at /BuildRoot/Library/Caches/com.apple.xbs/Sources/rsync/rsync-52.200.1/rsync/main.c(996) [sender=2.6.9]
"/Users/flutter/.cocoon/flutter/packages/flutter_tools/bin/xcode_backend.sh" exit code: 23
2020-11-02T19:21:23.664907: 
════════════════════════╡ ••• Xcode backend script ••• ╞════════════════════════

2020-11-02T19:21:23.317623: 
Executing: /Users/flutter/.cocoon/flutter/packages/flutter_tools/bin/xcode_backend.sh embed_and_thin in /Users/flutter/.cocoon/flutter/dev/devicelab with environment {SOURCE_ROOT: /var/folders/td/jlh092g928l86qfb9gs3dfvc0000gn/T/flutter_devicelab_gradle_plugin_test.U3lQ2v/hello/ios, TARGET_BUILD_DIR: /var/folders/td/jlh092g928l86qfb9gs3dfvc0000gn/T/flutter_devicelab_gradle_plugin_test.U3lQ2v/hello/build/ios/iphoneos, FRAMEWORKS_FOLDER_PATH: Runner.app/Frameworks, VERBOSE_SCRIPT_LOGGING: 1, FLUTTER_BUILD_MODE: release, ACTION: install}
2020-11-02T19:21:23.325129: stdout: ♦ mkdir -p -- /var/folders/td/jlh092g928l86qfb9gs3dfvc0000gn/T/flutter_devicelab_gradle_plugin_test.U3lQ2v/hello/build/ios/iphoneos/Runner.app/Frameworks
2020-11-02T19:21:23.329468: stdout: ♦ rsync -av --delete --filter - .DS_Store/ /App.framework /var/folders/td/jlh092g928l86qfb9gs3dfvc0000gn/T/flutter_devicelab_gradle_plugin_test.U3lQ2v/hello/build/ios/iphoneos/Runner.app/Frameworks
2020-11-02T19:21:23.334435: stdout: building file list ... done
stderr: rsync: link_stat "/App.framework" failed: No such file or directory (2)
stdout: 
stdout: sent 29 bytes  received 20 bytes  98.00 bytes/sec
stdout: total size is 0  speedup is 0.00
stderr: rsync error: some files could not be transferred (code 23) at /BuildRoot/Library/Caches/com.apple.xbs/Sources/rsync/rsync-52.200.1/rsync/main.c(996) [sender=2.6.9]
"/Users/flutter/.cocoon/flutter/packages/flutter_tools/bin/xcode_backend.sh" exit code: 23
2020-11-02T19:21:23.664907:

ios_content_validation_test_b770883_2 (2).log

TBR @jmagman

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 3, 2020
@google-cla google-cla bot added the cla: yes label Nov 3, 2020
@jonahwilliams jonahwilliams merged commit a2a4e9e into master Nov 3, 2020
@jonahwilliams jonahwilliams deleted the revert-69612-app-fw-build-loc branch November 3, 2020 04:12
@jmagman
Copy link
Member

jmagman commented Nov 3, 2020

Thanks, @jonahwilliams!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @jmagman