Fix a large number of Drawer bugs #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
There was a problem hiding this comment.
I think you should assert that you have one, rather than silently doing nothing if you don't.
Contributor
This patch restructures how we handle drawer. The drawer is now a child of the Scaffold, which wraps the Drawer in a DrawerController. The DrawerController manages the interaction with the navigator as well as the edge swiping. The DrawerController's state machine is driven almost entirely off its Performance, which it now owns completely. Fixes flutter#90 Fixes flutter#187 Fixes flutter#192 Fixes flutter#194 Fixes flutter#604
abarth
added a commit
that referenced
this pull request
Dec 3, 2015
Fix a large number of Drawer bugs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch restructures how we handle drawer. The drawer is now a child of the
Scaffold, which wraps the Drawer in a DrawerController. The DrawerController
manages the interaction with the navigator as well as the edge swiping. The
DrawerController's state machine is driven almost entirely off its Performance,
which it now owns completely.
Fixes #90
Fixes #187
Fixes #192
Fixes #194
Fixes #604