Repository navigation
[flutter_tools] retry sever socket setup (and port selection if port is unspecified) - #69351
Merged
Merged
Conversation
flutter-dashboard
Bot
added
the
tool
jonahwilliams
changed the title
yjbanov
approved these changes
Oct 30, 2020
| } | ||
| HttpServer httpServer; | ||
| dynamic lastError; | ||
| for (int i = 0; i < 5; i += 1) { |
Contributor
There was a problem hiding this comment.
If there's a way to tell that the SocketException is permament I'd do while (true)
Contributor
Author
There was a problem hiding this comment.
WDYM by permanent?
Contributor
Author
There was a problem hiding this comment.
I think generally no, if another program is holding this port we likely can't tell when it will terminate
| httpServer = await HttpServer.bind(address, port ?? await globals.os.findFreePort()); | ||
| break; | ||
| } on SocketException catch (error) { | ||
| lastError = error; |
Contributor
There was a problem hiding this comment.
Maybe insert await Future.delayed(Duration(milliseconds: 100)) or something? In case this is happening while something else is struggling to shut down?
13 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #69348
If the web development server fails to bind, then retry up to 5 times. If a port was not provided, select a new free port each time.