Skip to content

Show macOS arm64 architecture in doctor and devices list #69245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 4 commits into from
Oct 30, 2020
Merged

Show macOS arm64 architecture in doctor and devices list #69245

fluttergithubbot merged 4 commits into from
Oct 30, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Oct 28, 2020

Description

Add targetPlatformDisplayName for flutter doctor and flutter devices to show when the host is an Apple Silicon macOS ARM machine.

Do not add a more substantive TargetPlatform.darwin_arm64 change since the artifacts, build system, etc all require darwin_x64 even on ARM to leverage Rosetta translation.

Related Issues

Fixes #65976

Tests

macos_device_tests

@jmagman jmagman added the platform-mac Building on or for macOS specifically label Oct 28, 2020
@jmagman jmagman self-assigned this Oct 28, 2020
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 28, 2020
@google-cla google-cla bot added the cla: yes label Oct 28, 2020
christopherfujino
christopherfujino reviewed Oct 29, 2020
View reviewed changes
christopherfujino
christopherfujino approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: with a nit question

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Oct 29, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit de5bf09 into flutter:master Oct 30, 2020
@jmagman jmagman deleted the target-arm-mac branch February 2, 2021 19:04
@jmagman jmagman added the platform-host-arm Building on an ARM-based platform label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-host-arm Building on an ARM-based platform platform-mac Building on or for macOS specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[doctor] Add macOS architecture to doctor output

3 participants

@jmagman @fluttergithubbot @christopherfujino