Skip to content

[flutter_releases] Flutter 1.22.3 framework cherrypicks #69234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christopherfujino merged 4 commits into from
Oct 29, 2020
Merged

[flutter_releases] Flutter 1.22.3 framework cherrypicks #69234

christopherfujino merged 4 commits into from
Oct 29, 2020

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Oct 28, 2020 •
edited
Loading

Previous branch build

Scheduled Cherrypicks

Known Pre-submit Failures

  • LUCI customer_testing depends on a script in the recipes repo that clones customer_testing from HEAD.
  • build_tests-1_last-macos on cirrus failing running out of VM hard disk
  • windows + cirrus customer-testing and hostonly_devicelab failing to pub upgrade Cirrus Windows tests failing to pub upgrade #68250

Known Post-submit Failures

@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 28, 2020

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.22-candidate.12. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-1.22-candidate.12 to master October 28, 2020 19:54
@google-cla

This comment has been minimized.

Sign in to view
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Oct 28, 2020
@google-cla google-cla bot added the cla: no label Oct 28, 2020
@christopherfujino christopherfujino changed the base branch from master to flutter-1.22-candidate.12 October 28, 2020 19:54
@google-cla

This comment has been minimized.

Sign in to view
@google-cla

This comment has been minimized.

Sign in to view
@christopherfujino christopherfujino marked this pull request as ready for review October 29, 2020 19:50
justinmc
justinmc approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the text stuff 👍

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Oct 29, 2020

I updated the CLA label because the author in question has already signed the CLA

jonahwilliams
jonahwilliams approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino merged commit 8874f21 into flutter:flutter-1.22-candidate.12 Oct 29, 2020
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.22-candidate.12 branch October 29, 2020 21:14
@pcsosinski
Copy link

pcsosinski commented Oct 29, 2020

engine signed? (branch doc doesn't indicate)

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Oct 29, 2020

engine signed? (branch doc doesn't indicate)

thanks for checking, i'll update the doc now

@pcsosinski
Copy link

pcsosinski commented Oct 29, 2020

approved for branch

@christopherfujino christopherfujino mentioned this pull request Nov 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@pcsosinski pcsosinski Awaiting requested review from pcsosinski

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@christopherfujino @pcsosinski @justinmc @jonahwilliams @xu-baolin @mit-mit