Skip to content

InheritedTheme updates - #69050

Merged
fluttergithubbot merged 3 commits into
flutter:masterfrom
goderbauer:theme-part-1
Oct 27, 2020
Merged

fluttergithubbot merged 3 commits into
flutter:masterfrom
goderbauer:theme-part-1

Conversation

@goderbauer

@goderbauer goderbauer commented Oct 26, 2020 •

Copy link
Copy Markdown
Member

Description

Prepares the framework for the removal of the shadowThemeOnly parameter from Theme.of, which is in preparation of making Theme.of non-nullable.

In this change:

  • Add a new InheritedTheme.capture method that captures all themes between two given BuildContexts.
  • Change InerhitedTheme.wrap to always wrap unconditionally.
  • Replace all usages of shadowThemeOnly with InheritedTheme.capture.

The removal of shadowThemeOnly and making Theme.of non-nullable will follow in a separate PR.

Related Issues

Part of #67163.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Oct 26, 2020
@google-cla google-cla Bot added the cla: yes label Oct 26, 2020
@goderbauer
goderbauer requested a review from HansMuller October 26, 2020 20:01

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, this is a subset of #68922, which I've approved.

LGTM

@goderbauer

Copy link
Copy Markdown
Member Author

As I understand it, this is a subset of #68922, which I've approved.

Correct.

@fluttergithubbot

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux build_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows build_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
fluttergithubbot merged commit 9fb1c52 into flutter:master Oct 27, 2020
@goderbauer
goderbauer deleted the theme-part-1 branch October 27, 2020 16:34
@goderbauer goderbauer mentioned this pull request Oct 28, 2020
10 of 13 tasks
espresso3389 added a commit to espresso3389/flutter_datetime_picker that referenced this pull request Nov 4, 2020
cloudystef added a commit to cloudystef/form_bloc that referenced this pull request Nov 23, 2020
…t param has been replaced with InhertiedTheme.capture, see flutter/flutter#69050.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants