Repository navigation
Make Theme.of non-nullable - #68922
Merged
Merged
Conversation
flutter-dashboard
Bot
added
p: material_ui
goderbauer
force-pushed
the
theme
branch
2 times, most recently
from
October 26, 2020 18:08
784891e to
4025649
Compare
HansMuller
approved these changes
Oct 26, 2020
Contributor
There was a problem hiding this comment.
This is necessary with NNBD?
Member
Author
There was a problem hiding this comment.
While our customers still run without NNBD we still need them.
Member
Author
|
"Google testing" failures are from an unrelated change. |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
justprodev
added a commit
to justprodev/flutter_datetime_picker
that referenced
this pull request
Nov 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note to reviewers:
theme.dartcontains the only interesting change. Everything else is mechanical removal of 280!s.Description
Make
Theme.ofnon-nullable by removing theshadowThemeOnlyparam. That param has been replaced withInhertiedTheme.capture, see #69050.Related Issues
Fixes #67163.
Tests
I added the following tests:
n/a
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.