[flutter_tools] null safety mode is used for dill naming #68898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
Contributor
Author
|
Most of this change is plumbing, because the test config does not use buildInfo mostly. I can refactor that to be a bit easier to follow later (will require updating g3). |
jonahwilliams
commented
Oct 23, 2020
| // Temporary work around until --initialize-from-dill accounts for sound mode. | ||
| // The tool does not know the compilation mode if [NullSafetyMode.autodetect] is | ||
| // selected. | ||
| if (nullSafetyMode == NullSafetyMode.sound) { |
Contributor
Author
There was a problem hiding this comment.
This is the actual fix, everything else is plumbing
jason-simmons
approved these changes
Oct 23, 2020
zanderso
approved these changes
Oct 23, 2020
| @required bool trackWidgetCreation, | ||
| @required NullSafetyMode nullSafetyMode, | ||
| }) { | ||
| // Temporary work around until --initialize-from-dill accounts for sound mode. |
Member
There was a problem hiding this comment.
Could you file an issue for this?
| String randomSeed, | ||
| @required List<String> extraFrontEndOptions, | ||
| bool nullAssertions = false, | ||
| BuildInfo buildInfo // TODO(jonahwilliams): make the default argument |
Contributor
Author
There was a problem hiding this comment.
I'm about to head out, if you want to apply this change and re-run CI that is fine - otherwise I can clean this up next week when I make these required and update g3
Member
|
Landing before presubmits are finished to get rollers unblocked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A dill compiled in sound/unsound mode cannot be reused in
--initialize-from-dillfor compiling unsound/sound mode. Rename the file if sound mode is detected via command line argument.This does not work in the case of autodetect.
Fixes #68891