Skip to content

Apple silicon arch -arm64 to -arm64e #68855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Oct 23, 2020
Merged

Apple silicon arch -arm64 to -arm64e #68855

jmagman merged 1 commit into from
Oct 23, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Oct 23, 2020

Description

Confirmed arch -arm64e worked on Big Sur beta 10, suggested by @alexmarkley at #68050 (comment)

Related Issues

Adjustment of #68050
Fixes #65133

Tests

Update xcode_test.dart.

@jmagman jmagman added platform-ios iOS applications specifically platform-mac Building on or for macOS specifically t: xcode "xcodebuild" on iOS and general Xcode project management labels Oct 23, 2020
@jmagman jmagman self-assigned this Oct 23, 2020
@flutter-dashboard flutter-dashboard bot added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Oct 23, 2020
@google-cla google-cla bot added the cla: yes label Oct 23, 2020
@jmagman jmagman changed the title Apple silicon arch -arm64 -> -arm64e Apple silicon arch -arm64 to -arm64e Oct 23, 2020
@jmagman jmagman marked this pull request as ready for review October 23, 2020 17:28
@jmagman jmagman requested a review from jonahwilliams October 23, 2020 17:28
jonahwilliams
jonahwilliams approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@jmagman
Copy link
Member Author

jmagman commented Oct 23, 2020

Merging to kick the tree, mac_tool_tests is stuck on an infra failure

@jmagman jmagman merged commit 59544e3 into flutter:master Oct 23, 2020
@jmagman jmagman deleted the arme branch October 23, 2020 20:48
This was referenced Oct 27, 2020
Closed
Closed
jmagman added a commit to jmagman/flutter that referenced this pull request Oct 28, 2020
@jmagman
Apple silicon arch -arm64 -> -arm64e (flutter#68855)
ad526c8
@jmagman jmagman mentioned this pull request Oct 28, 2020
Closed
@jmagman jmagman added the platform-host-arm Building on an ARM-based platform label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-host-arm Building on an ARM-based platform platform-ios iOS applications specifically platform-mac Building on or for macOS specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"flutter build ios" fails on ARM macOS, ibtoold crashes compiling xcassets/storyboards

2 participants

@jmagman @jonahwilliams