Fix null safety error in inspector service extensions taking a variable number of args. #68661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… numbers of args. Fixes flutter#68627. Also fix all inspector tests that do not rely on golden image functionality so that they run with --enable-experiment=non-nullable. This verifies there is test coverage to ensure there isn't a regression.
flutter-dashboard
bot
added
the
framework
goderbauer
approved these changes
Oct 20, 2020
| final Object? jsonList = json.decode(service.getParentChain(bId, group)); | ||
| expect(jsonList, isList); | ||
| final List<Object> chainElements = jsonList! as List<Object>; | ||
| final List<dynamic> chainElements = jsonList! as List<dynamic>; |
Member
There was a problem hiding this comment.
Here and everywhere where dynamic is used: Why not Object?? I think that's what we've been using elsewhere for these cases.
Contributor
Author
There was a problem hiding this comment.
I've switched to using Object? everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where the setPubRootDirectories extension was failing in null safe mode.
Also fix all inspector tests that do not rely on golden image functionality
so that they run with --enable-experiment=non-nullable. This verifies there
is test coverage to ensure there isn't a regression.
Related Issues
Tests
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].