[null-safety] remove --no-sound-null-safety flag from widgets tests #68536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
c: contributor-productivity
added 3 commits
October 19, 2020 16:51
jonahwilliams
changed the title
jonahwilliams
commented
Oct 20, 2020
| await _runFlutterTest( | ||
| path.join(flutterRoot, 'packages', 'flutter'), | ||
| options: <String>[trackWidgetCreationOption, ...nullSafetyOptions], | ||
| options: <String>[trackWidgetCreationOption, ...nullSafetyOptions, '--sound-null-safety', '--enable-experiment=non-nullable'], |
Contributor
Author
There was a problem hiding this comment.
For some reason the experiment flag is required for sound null safety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Can be landed after sound mode support rolls again