Fix GridTileBar layout #6844
Merged
Fix GridTileBar layout #6844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarth
reviewed
Nov 14, 2016
abarth
reviewed
Nov 14, 2016
Contributor
Author
There was a problem hiding this comment.
Yes, that would be WAY better.
abarth
reviewed
Nov 14, 2016
Contributor
There was a problem hiding this comment.
Why are there only two cases now? I Would have expected the trailing == null and trailing != null cases to be treated differently.
Contributor
Author
There was a problem hiding this comment.
You're right, if there's no trailing widget the right pad should be 16, not 8.
HansMuller
force-pushed
the
grid_demo_fixes
branch
from
e8074ba to
21204c6
Compare
Contributor
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force GridTileBar heights to match the Material spec (https://material.google.com/components/grid-lists.html#grid-lists-specs) and simplify their layout a little.
Correct one more Scaffold body demo layout bug.
Fixes #6836