Skip to content

Conversation

@mkustermann
Copy link
Member

This is a pre-requisite to re-landing the flutter engine change in flutter/engine#21043 (comment)

@mkustermann mkustermann requested a review from Piinks as a code owner October 14, 2020 19:53
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 14, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Oct 14, 2020
@mkustermann mkustermann requested a review from a user October 14, 2020 19:53
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkustermann
Copy link
Member Author

mkustermann commented Oct 15, 2020

On my GCP windows VM the expression evaluation test successfully passes with this CL.

Will wait until tree is green and then land it.

@ghost
Copy link

ghost commented Oct 16, 2020

Tree looks green. Good to go?

(LGTM)

@mkustermann
Copy link
Member Author

Flutter tree has turned green, landing it now

@mkustermann mkustermann merged commit 6fae89c into flutter:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants