Skip to content

[devicelab] turn down android X migration gradle tests #68110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 3 commits into from
Oct 14, 2020
Merged

[devicelab] turn down android X migration gradle tests #68110

jonahwilliams merged 3 commits into from
Oct 14, 2020

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Oct 14, 2020 •
edited
Loading

Description

These androidx migration tests require downloading firebase, which is a large library with a number of dependencies - this causes frequent enough flakes.

AndroidX migration is ~2 years in the past, and while it would be nice to confirm this still works, ideally that would be done in a reduced manner.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Oct 14, 2020
@google-cla google-cla bot added the cla: yes label Oct 14, 2020
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Oct 14, 2020

It this the correct way to do it? or do I need to make recipe changes too?

@keyonghan
Copy link
Contributor

keyonghan commented Oct 14, 2020

It this the correct way to do it? or do I need to make recipe changes too?

For try jobs, these changes are enough. But for prod builders, these change will only avoid status showing up on flutter-dashboard, but these builders will still run and show up in the milo dashboard. So for the prod builders, flutter/infra config changes are needed to stop running them.

@godofredoc made quite some effort to make all these hostonly devicelab tests running, will leave approval to him.

godofredoc
godofredoc approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit c11a64e into flutter:master Oct 14, 2020
@jonahwilliams jonahwilliams deleted the fix_hot_reload_crash branch October 14, 2020 20:24
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Oct 14, 2020

FYI @blasten , these tests have been failing on and off for the past few weeks because the LUCI bots are having problems downloading the firebase dependencies. If we can find a way to run this test with a reduced or local only dependency then it could be re-added

@jmagman jmagman mentioned this pull request Apr 8, 2021
Open
16 tasks
@jmagman jmagman mentioned this pull request Jul 21, 2021
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keyonghan keyonghan Awaiting requested review from keyonghan

1 more reviewer

@godofredoc godofredoc godofredoc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @keyonghan @godofredoc