Skip to content

Remove legacy restart support #6801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johnmccutchan merged 1 commit into from
Nov 10, 2016
Merged

Remove legacy restart support #6801

johnmccutchan merged 1 commit into from
Nov 10, 2016

Conversation

@johnmccutchan
Copy link
Contributor

@johnmccutchan johnmccutchan commented Nov 10, 2016 •
edited
Loading

  • Remove restartApp and runFromFile from Device.
  • Do not support restarting in the non-hot runner.
  • Kill dead code.
  • Fix help text for debugDumpRenderTree

@johnmccutchan
Copy link
Contributor Author

johnmccutchan commented Nov 10, 2016

@devoncarew @Hixie

@Hixie
Copy link
Contributor

Hixie commented Nov 10, 2016

cc @jason-simmons who may have an opinion on this; I believe he uses this codepath daily.

@devoncarew
Copy link
Contributor

devoncarew commented Nov 10, 2016

Can you include the help output for flutter run --no-hot? I want to make sure that the text printed after an app starts up doesn't mention 'r to restart'.

lgtm for the code changes

@jason-simmons
Copy link
Member

jason-simmons commented Nov 10, 2016

fwiw, I find --no-hot helpful during engine development but I generally restart the entire application process on each rebuild versus using non-hot reload of Dart code.

@johnmccutchan
Copy link
Contributor Author

johnmccutchan commented Nov 10, 2016

@jason-simmons --no-hot isn't going away just application restart

@johnmccutchan
Copy link
Contributor Author

johnmccutchan commented Nov 10, 2016

@devoncarew The removal of the 'restart' help message can be seen here https://github.com/flutter/flutter/pull/6801/files#diff-7926ab5975b7b1656a34c7cd90f4ac7fL248

but just for sanity checking:

$ flutter run --no-hot
Running 'flutter packages get' in hello_world...    524ms
Building APK in debug mode (android-arm)...         5265ms
Installing build/app.apk...                         7610ms
Running lib/main.dart on Nexus 7...

The Observatory debugger and profiler is available at: http://127.0.0.1:45528/
For a more detailed help message, press "h" or F1. To quit, press "q", F10, or Ctrl-C.
h
The Observatory debugger and profiler is available at: http://127.0.0.1:45528/
To dump the widget hierarchy of the app (debugDumpApp), press "w".
To dump the rendering tree of the app (debugDumpRenderTree), press "r".
To repeat this help message, press "h" or F1. To quit, press "q", F10, or Ctrl-C.

which actually prints out bad help text. dumping the render tree is not "r" but "t".

@johnmccutchan
Copy link
Contributor Author

johnmccutchan commented Nov 10, 2016

help text fixed.

@johnmccutchan johnmccutchan merged commit e908655 into flutter:master Nov 10, 2016
@johnmccutchan johnmccutchan deleted the remove_legacy_restart branch November 22, 2016 00:01
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 9, 2018
Merged
dnfield pushed a commit that referenced this pull request Nov 9, 2018
@engine-flutter-autoroll @dnfield
Roll engine 22fc020..b2479f8 (10 commits) (#24137)
17fe191 
b2479f8 Revert "Roll src/third_party/skia 06a477c3300d..dd650c40d148 (11 commits) (#6801)" (flutter/engine#6809)
16f8c67 Update paint hinting for upcoming Skia API changes. (flutter/engine#6802)
e011d54 Roll src/third_party/skia 06a477c3300d..dd650c40d148 (11 commits) (flutter/engine#6801)
47ef89e Include vector in embedded_views.h (flutter/engine#6800)
a0efb94 Make the FlutterPlatformViewFactory create FlutterPlatformViews. (flutter/engine#6782)
7ed4909 Fix mDNS publishing for iOS simulator (flutter/engine#6789)
86d34e0 disable embedder_unittests (flutter/engine#6798)
01f6ad0 Roll src/third_party/skia 5d58d09ae77d..06a477c3300d (5 commits) (flutter/engine#6797)
18ca035 Discard embedded UIViews on hot restart. (flutter/engine#6772)
387ca2e Add an internal_nodes_canvas to PaintContext. (flutter/engine#6728)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@johnmccutchan @Hixie @devoncarew @jason-simmons