Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Oct 13, 2020

Description

Android Studio 4.1 moved the location of the .home file on Windows which is used to located the install directory. This functionality is important because it is how we locate and discover the Android SDK functionality, as well as the appropriate JRE.

fixes #67986

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 13, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jonahwilliams jonahwilliams changed the title [flutter_tools] support Android Studio 4.1 [flutter_tools] support Android Studio 4.1 on Windows Oct 13, 2020
@jonahwilliams
Copy link
Contributor Author

Google testing failure is a flake

@jonahwilliams jonahwilliams merged commit 1c97693 into flutter:master Oct 13, 2020
@jonahwilliams jonahwilliams deleted the android_studio_41 branch October 13, 2020 18:33
christopherfujino pushed a commit to chris-forks/flutter that referenced this pull request Oct 14, 2020
Android Studio 4.1 moved the location of the .home file on Windows which is used to located the install directory. This functionality is important because it is how we locate and discover the Android SDK functionality, as well as the appropriate JRE.

fixes flutter#67986
pcsosinski pushed a commit to pcsosinski/flutter that referenced this pull request Oct 15, 2020
Android Studio 4.1 moved the location of the .home file on Windows which is used to located the install directory. This functionality is important because it is how we locate and discover the Android SDK functionality, as well as the appropriate JRE.

fixes flutter#67986
pcsosinski pushed a commit that referenced this pull request Oct 15, 2020
)

* Update engine hash to 1.23.0-18.1.pre

* [flutter_tools] support Android Studio 4.1 on Windows (#67992)

Android Studio 4.1 moved the location of the .home file on Windows which is used to located the install directory. This functionality is important because it is how we locate and discover the Android SDK functionality, as well as the appropriate JRE.

fixes #67986

Co-authored-by: Jonah Williams <[email protected]>
christopherfujino added a commit that referenced this pull request Oct 15, 2020
* [flutter_tools] support Android Studio 4.1 on Windows (#67992)

Android Studio 4.1 moved the location of the .home file on Windows which is used to located the install directory. This functionality is important because it is how we locate and discover the Android SDK functionality, as well as the appropriate JRE.

fixes #67986

* [gestures] make stylus pointer types use touch pan/drag slop (#67885)

* Update engine cherrypicks

* pin customer_testing and add back windows to cirrus

Co-authored-by: Jonah Williams <[email protected]>
Luizgpp added a commit to Luizgpp/flutter that referenced this pull request Oct 30, 2020
* [flutter_tools] support Android Studio 4.1 on Windows (flutter#67992)

Android Studio 4.1 moved the location of the .home file on Windows which is used to located the install directory. This functionality is important because it is how we locate and discover the Android SDK functionality, as well as the appropriate JRE.

fixes flutter#67986

* [gestures] make stylus pointer types use touch pan/drag slop (flutter#67885)

* Update engine cherrypicks

* pin customer_testing and add back windows to cirrus

Co-authored-by: Jonah Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flutter Doctor: Android Studio 4.1 is not detected

2 participants