Skip to content

Revert "Pass RouteSettings to the internal Route in showCupertinoModalPopup" #67969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Oct 12, 2020
Merged

Revert "Pass RouteSettings to the internal Route in showCupertinoModalPopup" #67969

jonahwilliams merged 1 commit into from
Oct 12, 2020

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Oct 12, 2020

Reverts #56024

All pubspecs were up to date.
▌23:02:17▐ ELAPSED TIME: 1.143s for bin/flutter update-packages --verify-only in .
▌23:02:17▐ Dart analysis...
▌23:02:17▐ RUNNING: cd .; bin/flutter analyze --dartdocs --flutter-repo
Analyzing 3 directories...                                      

  error • Non-nullable instance field 'routeName' must be initialized • packages/flutter/test/cupertino/route_test.dart:1693:10 • not_initialized_non_nullable_instance_field
  error • 'RouteSettingsObserver.didPush' ('void Function(Route<dynamic>, Route<dynamic>)') isn't a valid override of 'NavigatorObserver.didPush' ('void Function(Route<dynamic>, Route<dynamic>?)') • packages/flutter/test/cupertino/route_test.dart:1696:8 • invalid_override
  error • A value of type 'String?' can't be assigned to a variable of type 'String' • packages/flutter/test/cupertino/route_test.dart:1698:19 • invalid_assignment

3 issues found. (ran in 119.6s)

TBR @goderbauer

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Oct 12, 2020
@google-cla google-cla bot added the cla: yes label Oct 12, 2020
@jonahwilliams jonahwilliams merged commit 8aee75f into master Oct 12, 2020
@jonahwilliams jonahwilliams deleted the revert-56024-mb-cupertinomodal-settings branch October 12, 2020 23:09
@nturgut nturgut mentioned this pull request Oct 12, 2020
Merged
@goderbauer
Copy link
Member

goderbauer commented Oct 12, 2020

Thanks

/cc @miquelbeltran Can you recreate your PR based on the latest master branch to fix those problems?

@miquelbeltran miquelbeltran mentioned this pull request Oct 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @goderbauer