Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Oct 12, 2020

Description

A user reported that they could not drag/pan/scale correctly anymore. Revert the stylus values to the old settings.

Fixes #67869

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. work in progress; do not review labels Oct 12, 2020
@google-cla google-cla bot added the cla: yes label Oct 12, 2020
@jonahwilliams jonahwilliams marked this pull request as ready for review October 12, 2020 17:51
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@jonahwilliams
Copy link
Contributor Author

Failure is single flaky fuchsia bot, skipping.

@jonahwilliams jonahwilliams merged commit c606f04 into flutter:master Oct 12, 2020
@jonahwilliams jonahwilliams deleted the stylus_back branch October 12, 2020 22:22
christopherfujino pushed a commit to chris-forks/flutter that referenced this pull request Oct 14, 2020
christopherfujino added a commit that referenced this pull request Oct 15, 2020
* [flutter_tools] support Android Studio 4.1 on Windows (#67992)

Android Studio 4.1 moved the location of the .home file on Windows which is used to located the install directory. This functionality is important because it is how we locate and discover the Android SDK functionality, as well as the appropriate JRE.

fixes #67986

* [gestures] make stylus pointer types use touch pan/drag slop (#67885)

* Update engine cherrypicks

* pin customer_testing and add back windows to cirrus

Co-authored-by: Jonah Williams <[email protected]>
Luizgpp added a commit to Luizgpp/flutter that referenced this pull request Oct 30, 2020
* [flutter_tools] support Android Studio 4.1 on Windows (flutter#67992)

Android Studio 4.1 moved the location of the .home file on Windows which is used to located the install directory. This functionality is important because it is how we locate and discover the Android SDK functionality, as well as the appropriate JRE.

fixes flutter#67986

* [gestures] make stylus pointer types use touch pan/drag slop (flutter#67885)

* Update engine cherrypicks

* pin customer_testing and add back windows to cirrus

Co-authored-by: Jonah Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stylus tap gesture registering as drag/pan

2 participants