Skip to content

Remove uses of Dart VM bytecode mode #67755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexmarkov merged 1 commit into from
Oct 9, 2020
Merged

Remove uses of Dart VM bytecode mode #67755

alexmarkov merged 1 commit into from
Oct 9, 2020

Conversation

@alexmarkov
Copy link
Contributor

@alexmarkov alexmarkov commented Oct 9, 2020 •
edited
Loading

Description

Bytecode mode of Dart VM is deprecated and will be removed soon. This change cleans up remaining uses of bytecode mode in Flutter.

Tests

This is a pure cleanup and should be covered by existing tests.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 9, 2020
@google-cla google-cla bot added the cla: yes label Oct 9, 2020
jonahwilliams
jonahwilliams approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams
Copy link
Contributor

jonahwilliams commented Oct 9, 2020

(I think there might be some other tests that cover this which you'll need to update, but CI will show that )

@alexmarkov alexmarkov mentioned this pull request Oct 9, 2020
Merged
10 tasks
@alexmarkov alexmarkov merged commit 1973cf2 into flutter:master Oct 9, 2020
@alexmarkov alexmarkov deleted the remove-bytecode branch October 9, 2020 23:33
@jmagman jmagman mentioned this pull request Dec 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaselatta chaselatta Awaiting requested review from chaselatta

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

@a-siva a-siva Awaiting requested review from a-siva

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexmarkov @jonahwilliams