Reland "[null-safety] reland: migrate app side flutter driver to null-safety" #67570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: accessibility
goderbauer
changed the title
added 2 commits
October 8, 2020 15:03
…-revert-67441-migrate_flutter_driver
jonahwilliams
commented
Oct 8, 2020
| @override | ||
| Map<String, String> serialize() => super.serialize()..addAll(<String, String>{ | ||
| 'message': message, | ||
| if (message != null) |
Contributor
Author
There was a problem hiding this comment.
This is the fix
Member
There was a problem hiding this comment.
Ahhh, OK, I was misunderstanding the ! because I wasn't seeing the != null around it; it's used to remove the ? from the type of the variable. Cool beans!
jonahwilliams
commented
Oct 8, 2020
| import '../../common.dart'; | ||
|
|
||
| void main() { | ||
| test('RequestData does not insert "null" string when no message is provided', () { |
Contributor
Author
There was a problem hiding this comment.
Unit test for this
fluttergithubbot
deleted the
revert-67561-revert-67441-migrate_flutter_driver
branch
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #67561
Fixes insertion of
nullstring into message data which crashed integration with web driver. Adds unit test to coverFixes #67560